-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wilmoth model LT ported #102
Conversation
latest build fixes
LofQuad family of model life tables ported from MortalityEstimate::wilmothLT. Fitted models based on the whole current HMD for both sex, females and males are saved as internal data objects
AppVeyor: Status: 1 WARNING, 1 NOTE
Travis: Found warnings, treating as errors (as requested). I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about you clear up these two comments, recommit, and add it to the PR? I won't be doing work on this until tomorrow most likely, but might be able to attend to small things in late afternoon. Thanks!
fitted_logquad | ||
} else { | ||
if(is.null(fitted_logquad)){ | ||
|
||
if(Sex == "b"){ | ||
fitted_logquad <- fitted_logquad_b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the warning about fitted_logquad_b
not being visible would be overcome by using data(fitted_logquad_b)
? Just a guess without googling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check
Funny, there was no warning on my machine, only the visibility note |
good tips here:
http://r-pkgs.had.co.nz/data.html
…On Thu, Dec 5, 2019 at 4:25 PM Ilya Kashnitsky ***@***.***> wrote:
Funny, there was no warning on my machine, only the visibility note
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#102?email_source=notifications&email_token=AAG43G5LD5VYDCG4ETX6UM3QXEMQBA5CNFSM4JVMIQWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBCP3A#issuecomment-562178028>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG43G3GODL5JSVIVFC5NIDQXEMQBANCNFSM4JVMIQWA>
.
|
I'm merging this in and will try to fix errors/warnings/notes |
The error sits somewhere in the changed identity functions.
|
Hi I’m making lots of changes on my end inside these functions, will pick
up again 14:00. Chgs not yet committed tho. Will get to the bottom of it
…On Fri, Dec 6, 2019 at 10:14 AM Ilya Kashnitsky ***@***.***> wrote:
The error sits somewhere in the changed identity functions.
Error in lt_id_ma_q(nMx = M0, nax = a0, AgeInt = 1, closeout = FALSE, :
n == length(nax) is not TRUE
Calls: lt_model_lq ... lt_id_morq_a_greville -> lt_rule_4a1_cd -> lt_id_ma_q -> stopifnot
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#102?email_source=notifications&email_token=AAG43G4OMC4WENB5WEQS5ITQXIJWRA5CNFSM4JVMIQWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGDPZ4Q#issuecomment-562494706>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG43G6J4ZY7Y6YPZ5523LTQXIJWRANCNFSM4JVMIQWA>
.
----------
This mail has been sent through the MPI for Demographic Research. Should you receive a mail that is apparently from a MPI user without this text displayed, then the address has most likely been faked. If you are uncertain about the validity of this message, please check the mail header or ask your system administrator for assistance.
|
LogQuad family of model life tables ported from MortalityEstimate::wilmothLT. Fitted models based on the whole current HMD for both sex, females and males are saved as internal data objects