Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wilmoth model LT ported #102

Merged
merged 8 commits into from
Dec 6, 2019
Merged

Wilmoth model LT ported #102

merged 8 commits into from
Dec 6, 2019

Conversation

ikashnitsky
Copy link
Contributor

LogQuad family of model life tables ported from MortalityEstimate::wilmothLT. Fitted models based on the whole current HMD for both sex, females and males are saved as internal data objects

LofQuad family of model life tables ported from MortalityEstimate::wilmothLT. Fitted models based on the whole current HMD for both sex, females and males are saved as internal data objects
@ikashnitsky
Copy link
Contributor Author

AppVeyor: Status: 1 WARNING, 1 NOTE

* checking Rd cross-references ... WARNING
Unknown package 'MortalityEstimate' in Rd xrefs

Travis: Found warnings, treating as errors (as requested). I

Copy link
Owner

@timriffe timriffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about you clear up these two comments, recommit, and add it to the PR? I won't be doing work on this until tomorrow most likely, but might be able to attend to small things in late afternoon. Thanks!

fitted_logquad
} else {
if(is.null(fitted_logquad)){

if(Sex == "b"){
fitted_logquad <- fitted_logquad_b
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the warning about fitted_logquad_b not being visible would be overcome by using data(fitted_logquad_b)? Just a guess without googling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check

R/lt_model_lq.R Outdated Show resolved Hide resolved
@ikashnitsky
Copy link
Contributor Author

Funny, there was no warning on my machine, only the visibility note

@timriffe
Copy link
Owner

timriffe commented Dec 5, 2019 via email

@timriffe
Copy link
Owner

timriffe commented Dec 6, 2019

I'm merging this in and will try to fix errors/warnings/notes

@timriffe timriffe merged commit d91a11c into timriffe:master Dec 6, 2019
@ikashnitsky
Copy link
Contributor Author

The error sits somewhere in the changed identity functions.

Error in lt_id_ma_q(nMx = M0, nax = a0, AgeInt = 1, closeout = FALSE,  : 
  n == length(nax) is not TRUE
Calls: lt_model_lq ... lt_id_morq_a_greville -> lt_rule_4a1_cd -> lt_id_ma_q -> stopifnot

@timriffe
Copy link
Owner

timriffe commented Dec 6, 2019 via email

@ikashnitsky ikashnitsky mentioned this pull request Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants