Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support for the Logitech Litra Beam LX #294

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

timrogers
Copy link
Owner

This pull request adds basic support for the Logitech Litra Beam LX, a new Litra device from Logitech.

The code is inspired by @lnovelli's fork of this project, where @lnovelli has already kindly worked out the new device's details and how it works 馃挏

For now, this just supports our existing functionality (managing the device's on/off state, brightness and temperature), and not the Litra Beam LX's coloured RGB zone.

Fixes #288.

This pull request adds basic support for the Logitech Litra Beam
LX, a new Litra device from Logitech.

The code is inspired by [@lnovelli](https://github.com/lnovelli/litra-lx)'s
fork of this project, where @lnovelli has already kindly worked
out the new device's details and how it works 馃挏

For now, this just supports our existing functionality (managing
the device's on/off state, brightness and temperature), and not
the Litra Beam LX's coloured RGB zone.

Fixes #288.
@timrogers
Copy link
Owner Author

timrogers commented Dec 23, 2023

@jbsparrow Would you be willing to give this a try for me? 馃檹馃徎

All you need to do is clone this repo and install the dependencies with npm i, and then this should be ready for testing. Could you please try the following for me?

  • Run node dist/commonjs/cli/litra-devices.js - your device should be listed as a Litra Beam LX in the "off" state
  • Run node dist/commonjs/cli/litra-on.js - your device should turn on
  • Run node dist/commonjs/cli/litra-devices.js - your device should now show in the "on" state
  • Run node dist/commonjs/cli/litra-toggle.js twice - your device should turn off, then on again
  • Run node dist/commonjs/cli/litra-brightness-lm.js 80 - your device's brightness should change
  • Run node dist/commonjs/cli/litra-temperature-k.js 3200 - your device's temperature should change

Once we've run through that quickly and things seem to be working, I'd love to merge and release this 馃コ

@timrogers
Copy link
Owner Author

@lnovelli You'd also be welcome to try the steps above, if you have a chance 馃檹馃徎

@jbsparrow
Copy link

I'm so sorry I wasn't able to get back to you earlier. I just gave it a try and it works perfect! Would it be possible to add support for the RGB backlight at some point? I was taking a look at the code but unfortunately I really don't have any experience with node so I wasn't able to figure out.

Copy link

@jbsparrow jbsparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and all features work perfect. I think it's good to go!

@timrogers
Copy link
Owner Author

I'm so sorry I wasn't able to get back to you earlier. I just gave it a try and it works perfect!

Thank you 鉂わ笍

Would it be possible to add support for the RGB backlight at some point? I was taking a look at the code but unfortunately I really don't have any experience with node so I wasn't able to figure out.

Yep! I definitely want to come back to this, but I wanted to do a simple implementation first.

@timrogers timrogers merged commit 31b67c5 into main Jan 8, 2024
3 checks passed
Copy link

github-actions bot commented Jan 8, 2024

馃帀 This PR is included in version 4.5.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with Logitech Litra Beam LX
2 participants