Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] Chicken Breeder Showing Negative Numbers #13

Closed
MokahTGS opened this issue Dec 2, 2017 · 22 comments
Closed

[1.12.2] Chicken Breeder Showing Negative Numbers #13

MokahTGS opened this issue Dec 2, 2017 · 22 comments

Comments

@MokahTGS
Copy link

MokahTGS commented Dec 2, 2017

https://www.dropbox.com/s/ogq8kjcvc5n719i/Negative%20chickens.png?dl=0

We are having an issue with the breeders where they will sometimes show negative numbers and that will stop them breeding. This seems to be random and sometimes gets stuck that way and sometimes it fixes itself.

Is this a bug or feature?

Forge 2537
Roost 1.2.0

@timrwood
Copy link
Owner

timrwood commented Dec 4, 2017

This is a bug, I'll look into it.

@timrwood timrwood added the bug label Dec 4, 2017
@katubug
Copy link

katubug commented Dec 17, 2017

Just wanted to report that I am also having this issue. It occurs randomly, but it seems to be more prevalent the higher tier the chicken. For example, my diamond chickens and my blaze rod chickens (both second or third generation of their type) seem to be utterly unable to breed now. They ONLY produce negative percentages.

These negative percentages exceed 100% as well, so I don't think it's a visual bug.

Let me know if there's anything I can provide to help you troubleshoot.

Edit: Actually, it may be a visual bug somehow. When IN the breeder, it shows negative numbers. When looking at it from the outside, WAILA tells me it is at a smaller, positive percentage.

@UncertifiedDevice
Copy link

I'm having this issue too.
The progress will go negative seemingly randomly when I start breeding chickens. Once negative the progress will go to some number below -100 and then it will become positive and start counting down to 100, very strange and I'm not sure why it happens but I have observed that seems to happen more often with certain modded chickens. For example I have noticed this happening more often with clay, slime, silicon and blaze chickens but not so much with sand, log or regular chickens.

@UncertifiedDevice
Copy link

I just discovered this can happen with Roosts too
image

@UncertifiedDevice
Copy link

I just ran into the most extreme example I've seen so far of this, While breeding emerald chickens, one with growth 3 and the other with growth 2 the negative progress went all the way down to -570 before it started counting down. The picture is while it is counting down.
image

@timrwood
Copy link
Owner

Could you paste the chickens.cfg and morechickens.cfg files from that world save? It should look something like this: https://gist.github.com/timrwood/b77ca91b7a42cca853b94c844e541c7d

@UncertifiedDevice
Copy link

Here's both configs for the pack I'm playing chickens.cfg and morechickens.cfg. I would also like to add something more, I never noticed this before but @katubug is right about WAILA (or whatever it's called right now) showing a reliable progress %age. This bug might just be visual but it definitely threw me off and some other people on a server.

@katubug
Copy link

katubug commented Dec 26, 2017

Here are my configs as well, if they help:

chickens.json and morechickens.json

@notloki
Copy link

notloki commented Jan 27, 2018

I've noticed as a work around you can pull the chicken in and out quickly a few times and it will go positive

@katubug
Copy link

katubug commented Jan 27, 2018 via email

@timrwood
Copy link
Owner

I found the issue. https://github.com/timrwood/roost/blob/master/src/main/java/com/timwoodcreates/roost/inventory/ContainerBreeder.java#L64 is truncating values to a short.

/**
 * Sends two ints to the client-side Container. Used for furnace burning time, smelting progress, brewing progress,
 * and enchanting level. Normally the first int identifies which variable to update, and the second contains the new
 * value. Both are truncated to shorts in non-local SMP.
 */
void sendWindowProperty(Container containerIn, int varToUpdate, int newValue);

For higher tier chickens, timeUntilNextDrop is outside the -32,768 .. 32,767 range, so it overflows to a negative number. I have a fix that will only send 0-1000 no matter what tier chickens are used.

@fraggynator
Copy link

The whole thing is really strange in my opinion.
Especially since they will still breed. In my "breeder plant" where I 10/10/10 the needed chickens I have the offspring removed automatically. If I set 2 iridium chickens and for some reason they don't bug out they will certainly bug out after producing 1 offspring. But at some point they will produce another offspring regardless.

@Ratismal
Copy link

Considering that the source of this issue was discovered over a month ago, can we expect a fix to be implemented any time soon?

@Matakor
Copy link

Matakor commented Mar 20, 2018

Would certainly appreciate it. I can't get tungstensteel chickens at all thanks to tungsten chickens just refusing to do anything.. Every value is negative, and if it does go positive, they fail and continue past, not giving anything. Both in breed and roost, it's a nightmare. :\

@mdctyud
Copy link

mdctyud commented Mar 24, 2018

I'm in the same boat with Modern Skyblock 3. Can't progress the quest as the chickens can't/won't breed anymore. :(

@Matakor
Copy link

Matakor commented Mar 24, 2018

Update on that actually. After just leaving the chickens in place for a while, they did actually breed.

Took a while, but it appears to me that the 'negative numbers' are simply a gui failure? Was able to breed all the way to draconium/awakened draconium and full 10/10/10 for each by ignoring the number.

@stevojhall
Copy link

as an update while we wait for 1.3.0 i have found that shift clicking a chicken in and out of the breeder works better for me as the breeder does not seem to want to let me click fast (checking the percentage is positive and not negative each time)

@ShaneCourtrille
Copy link

@timrwood can we get a release with just this fixed? Huge pain in the butt..

@timrwood
Copy link
Owner

timrwood commented Nov 5, 2018

I added an alpha release file to CurseForge, if everything looks good, I'll promote it to the official 1.3.0 release.

https://minecraft.curseforge.com/projects/roost/files/2635449

@melbellrocks
Copy link

i manually updated my ftb sky adventures install with the alpha and haven't had any issues. no more negative numbers :D thanks!

@timrwood
Copy link
Owner

timrwood commented Nov 6, 2018

This is fixed in 1.3.0

@timrwood timrwood closed this as completed Nov 6, 2018
@AndreLouisIssa
Copy link

While I trust this is fixed in 1.3.0, I thought I'd add some of my screenshots I took while on my server.
2018-11-15_00 36 08
2018-11-15_00 49 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests