fix: Fixed EQ band out-of-range crash

timschneeb · Aug 1, 2023 · 2eccc97 · 2eccc97
1 parent b33784a
commit 2eccc97
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.idea/gradle.xml b/.idea/gradle.xml
diff --git a/app/src/main/java/me/timschneeberger/rootlessjamesdsp/view/BaseEqualizerSurface.kt b/app/src/main/java/me/timschneeberger/rootlessjamesdsp/view/BaseEqualizerSurface.kt
@@ -15,6 +15,7 @@ import androidx.core.content.withStyledAttributes
 import androidx.core.os.bundleOf
 import me.timschneeberger.rootlessjamesdsp.utils.extensions.CompatExtensions.getParcelableAs
 import me.timschneeberger.rootlessjamesdsp.utils.extensions.prettyNumberFormat
+import timber.log.Timber
 import java.util.Locale
 import kotlin.math.abs
 import kotlin.math.exp
@@ -231,6 +232,11 @@ abstract class BaseEqualizerSurface(
     }
 
     fun setBand(i: Int, value: Double) {
+        if(i < 0 || i >= bandsNum) {
+            Timber.e("setBand($i): $i is out of range")
+            return
+        }
+
         mLevels[i] = value
         postInvalidate()
     }