This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
androidx #485
Open
androidx #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library version set to 1.0.0, will have to be set to latest stable version
THis class is private within the support library now
|
Thanks for this George. I will review this over the weekend |
Observed on release variants with crash log java.lang.IllegalStateException: Failed to set TextInputLayout hint (collapsed) color: null at com.afollestad.aesthetic.cb.b(SourceFile:10) at com.afollestad.aesthetic.Aa.a(SourceFile:3) at com.afollestad.aesthetic.Aa.accept(SourceFile:1) at io.reactivex.internal.observers.LambdaObserver.a(SourceFile:7) at io.reactivex.internal.operators.observable.ObservableDistinctUntilChanged$DistinctUntilChangedObserver.a(SourceFile:10) at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.e(SourceFile:8) at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run(SourceFile:3) at io.reactivex.android.schedulers.HandlerScheduler$ScheduledRunnable.run(SourceFile:1) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6672) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:860)
|
Putting back WIP as some issues exist with CollapsingToolbars in detail screens |
Refactor directories to use the classes from androidx libraries Refactor some declarations to match up the above changes. This commit also reverts 46dbd95.
|
@GeoZac is this all working / ready to be reviewed? |
|
Yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Android support libraries were deprecated and androidx is out, Shuttle should also take the step.
Needs thorough review (Optimizing imports should help in maintainability in future)