Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Include contrib folder into the crates.io tarball #102

Merged
merged 1 commit into from
Dec 5, 2019
Merged

chore: Include contrib folder into the crates.io tarball #102

merged 1 commit into from
Dec 5, 2019

Conversation

ignatenkobrain
Copy link
Contributor

Otherwise distributions can't make completions available.

@ignatenkobrain
chore: Include contrib folder into the crates.io tarball
c740ddc 
Otherwise distributions can't make completions available.
@ignatenkobrain
Copy link
Contributor Author

@timvisee I would appreciate if you could release new release after this is merged.

@timvisee timvisee self-assigned this Dec 5, 2019
@timvisee timvisee added the enhancement New feature or request label Dec 5, 2019
@timvisee
Copy link
Owner

timvisee commented Dec 5, 2019

Thanks for the PR!

timvisee added a commit that referenced this pull request Dec 5, 2019
@timvisee
Merge branch 'ignatenkobrain-patch-1'
31c5fff 
See #102
@timvisee timvisee merged commit c740ddc into timvisee:master Dec 5, 2019
@timvisee
Copy link
Owner

timvisee commented Dec 5, 2019 •
edited
Loading

This is included in v0.2.57. The crate should be available as soon as the release-crate job succeeds (which may take up to an hour):
https://gitlab.com/timvisee/ffsend/pipelines/100914839

@ignatenkobrain
Copy link
Contributor Author

@timvisee amazing, thanks!

One more thing, can you release new update of ffsend-api with derive_builder dependency bumped to 0.9? Same as ffsend requires now.

@ignatenkobrain
Copy link
Contributor Author

And websocket 0.24.x, pretty please :)

@timvisee
Copy link
Owner

timvisee commented Dec 5, 2019 •
edited
Loading

@ignatenkobrain Done so in ffsend-api v0.4.2 at 0bf730d. Updated other crates (that didn't require code changes) as well.

Of course, this new ffsend-api version isn't included in ffsend yet.

In case you're wondering, the ffsend-api crate is releasing here:
https://gitlab.com/timvisee/ffsend-api/pipelines/100916852
https://gitlab.com/timvisee/ffsend-api/pipelines/100918165
https://gitlab.com/timvisee/ffsend-api/pipelines/100922316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timvisee timvisee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignatenkobrain @timvisee