Fix glitchy UI dropdown select for max downloads and expiration #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
requested changes
May 19, 2021
|
Ok applied the changes. I haven't tested the latest version yet myself though, so don't merge it immediately. If you have a chance to test it and it works, feel free to merge it. Otherwise, I'll post back in a day or two once I've had a chance to spin up a dev server and test it across a few browsers and config setups. |
|
I'll try to give it a spin soon. |
timvisee
approved these changes
May 19, 2021
|
I've tested the branch with Firefox and Chrome, which seems to work fine. The new config function did not parse a string array correctly, but I'll fix that on master. Thanks! |
timvisee
added a commit
that referenced
this pull request
May 19, 2021
|
I've released this as part of It should be available when this pipeline succeeds: https://gitlab.com/timvisee/send/-/pipelines/305718044 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug with the UI selection dropdowns where config values
EXPIRE_TIMES_SECONDSandDOWNLOAD_COUNTSloaded as string arrays fail the strictif (existing val !== chosen val) set...check in the dropdown onchange handler https://github.com/timvisee/send/pull/36/files#diff-a9e45594669203e5e550875e43529ae26c24aeffb9af1bb0ba333015f471447cL15-R23, causing this glitchy behavior:There is no way to provide the
EXPIRE_TIMES_SECONDSandDOWNLOAD_COUNTSconfig values as integer arrays with Docker, so this PR fixes the handling in the case that they are string arrays (as they always are when set via env vars). It also adds some logging to make it clearer in the console and from the HTML which item is selected and fixes a race condition between the form selection change and signup modal popup.PR Roadmap:
masterbehavior with default config value:works as expected, dropdowns chose values and do not reset on changemasterbehavior with config values changed via env var to string array:broken, dropdowns reset on change (see screen recording)TODOTODOTODO