Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking more types of text in payload #1801

Merged
merged 1 commit into from
May 27, 2024

Conversation

joshbermanssw
Copy link
Contributor

As per #1798 the blog posts were not including text that was not of type 'text'. Therefore all text of type was being dismissed. This change modified the getExcerpt method used to retrieve text from posts, making sure we include anchored text and map it to text.

Screenshot 2024-05-27 at 10 58 59 am

Figure: After the change has been implemented, text now appears

@joshbermanssw joshbermanssw requested a review from a team as a code owner May 27, 2024 01:05
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 1:05am

@JackDevAU
Copy link
Member

Just for clarification - this PR turns tags inside content that weren't previously displayed into normal text and removes the link so it isn't clickable?

@joshbermanssw
Copy link
Contributor Author

Just for clarification - this PR turns tags inside content that weren't previously displayed into normal text and removes the link so it isn't clickable?

Yes, for the 'preview' screen on our 'Recent Posts' section. Before it was grabbing text that was strictly 'text' type

@joshbermanssw joshbermanssw merged commit d8f9817 into main May 27, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the fix-recent-posts-body-method branch May 27, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants