-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup docs-navigation (PR from TinaCMS) #1917
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Tina.io content can be edited by lots of people, there is a good chance an editor will forget to enter this info.
It's important we write code that is resilient and handles not just the happy path, but all the weird things users will do (unhappy paths).
Add the following as steps in the issue
- CMS - make
prev
andnext
required fields (see https://tina.io/docs/reference/fields/) - react code - handle the situation where these values might be null.
Tip: Assume your users are editing content for the first time... what mistakes might they make?
cc: @bradystroud
As per our conversation, not all items should have links both directions. Rather we should fix the UI so items without a forward or backwards link dont look like they have broken pagination.
Following on the last point, fields can be null. UI should be better (#1929) |
As per #1916 this PR addresses the navigation between docs pages