Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup docs-navigation (PR from TinaCMS) #1917

Merged
merged 51 commits into from
Jul 22, 2024

Conversation

tina-cloud-app[bot]
Copy link
Contributor

@tina-cloud-app tina-cloud-app bot commented Jul 15, 2024

As per #1916 this PR addresses the navigation between docs pages

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 6:51am

@joshbermanssw joshbermanssw marked this pull request as ready for review July 19, 2024 04:08
@joshbermanssw joshbermanssw requested a review from a team as a code owner July 19, 2024 04:08
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Tina.io content can be edited by lots of people, there is a good chance an editor will forget to enter this info.

It's important we write code that is resilient and handles not just the happy path, but all the weird things users will do (unhappy paths).

Add the following as steps in the issue

  1. CMS - make prev and next required fields (see https://tina.io/docs/reference/fields/)
  2. react code - handle the situation where these values might be null.

Tip: Assume your users are editing content for the first time... what mistakes might they make?

@joshbermanssw
Copy link
Contributor

cc: @bradystroud

  1. CMS - make prev and next required fields

As per our conversation, not all items should have links both directions. Rather we should fix the UI so items without a forward or backwards link dont look like they have broken pagination.

  1. react code - handle the situation where these values might be null.

Following on the last point, fields can be null. UI should be better (#1929)

@joshbermanssw joshbermanssw merged commit 6b17b8a into main Jul 22, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the tina/cleanup-docs-navigation branch July 22, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants