Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary version of Scala.js turned to "1", not "1.0" as of version 1.0.0 #91

Closed
dtw-waleee opened this issue Mar 15, 2020 · 2 comments · Fixed by #92
Closed

Binary version of Scala.js turned to "1", not "1.0" as of version 1.0.0 #91

dtw-waleee opened this issue Mar 15, 2020 · 2 comments · Fixed by #92

Comments

@dtw-waleee
Copy link

This leads to errors when retrieving artifacts in the form of eg.:
Could not resolve dependency slinky-core_sjs1.0_2.13 in me.shadaj

Mill had to change some hardoded cases, which I guess is the case for seed too?

tindzk added a commit that referenced this issue Mar 22, 2020
From v1.0 onwards, the binary tag does not contain the minor version
anymore.

Closes #91.
tindzk added a commit that referenced this issue Mar 22, 2020
From v1.0 onwards, the binary tag does not contain the minor version
anymore.

Closes #91.
@tindzk
Copy link
Owner

tindzk commented Mar 23, 2020

Thanks for the bug report! I have merged a fix. Feel free to try it with the latest pre-release.

Please note that Seed does not officially support Scala.js v1.0 modules yet because Bloop v1.3.2 cannot link them. Once the next stable Bloop version has been released, I am hoping to add integration tests.

@dtw-waleee
Copy link
Author

Great! I did a smaller more hackish workaround in seed on my local machine, but I ran into the bloop issue, so I didn't think it merited a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants