Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Angular 6 #17

Closed
Juchar opened this issue Jun 28, 2018 · 1 comment
Closed

Update for Angular 6 #17

Juchar opened this issue Jun 28, 2018 · 1 comment

Comments

@Juchar
Copy link

Juchar commented Jun 28, 2018

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

OS and Version?

Windows 7

Versions

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 6.0.8
Node: 8.11.3
OS: win32 x64
Angular: 6.0.6
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.1
typescript                        2.7.2
webpack                           4.8.3
ngx-cookieconsent                 1.0.1

Repro steps

Simply follow the documentation to include it in your application using angular-cli.

The log given by the failure

ERROR in ./node_modules/ngx-cookieconsent/service/cookieconsent.service.js
Module not found: Error: Can't resolve 'rxjs/Subject' in 'my\project\here\node_modules\ngx-cookieconsent\service'

Desired functionality

No compiler error.

Mention any other details that might be useful

I assume this is due to the changes paths in RxJs 6 that is used together with Angular 6.

@tinesoft
Copy link
Owner

Hi @Juchar

You assumption is correct.
Angular v6 update is coming very shortly.
In the meantime, you can install rxjs-compat.

Stay tuned

tinesoft added a commit that referenced this issue Jul 18, 2018
- update demo application and add SSR support

BREAKING CHANGE:

The mininmum version of Angular is now v6+ and of Node is v8+

Closes #17 and #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants