Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using remote Azure IP Networks which allows loading when the application starts #240

Merged
merged 1 commit into from
May 5, 2024
Merged

Allow using remote Azure IP Networks which allows loading when the application starts #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions src/Tingle.AspNetCore.Authorization/AuthorizationPolicyBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public static AuthorizationPolicyBuilder RequireApprovedNetworks(this Authorizat
}

/// <summary>
/// Adds an <see cref="ApprovedIPNetworkRequirement"/> to the current instance, using Known Azure IPs.
/// Adds an <see cref="ApprovedIPNetworkRequirement"/> to the current instance, using known Azure IPs that are cached locally.
/// Ensure the necessary Authorization and framework services are added to the same collection
/// using <c>services.AddApprovedNetworksHandler(...)</c>.
/// Networks used are retrieved using <see cref="AzureIPNetworks.AzureIPsHelper"/>.
Expand All @@ -110,12 +110,36 @@ public static AuthorizationPolicyBuilder RequireAzureIPNetworks(this Authorizati
AzureIPNetworks.AzureCloud cloud = AzureIPNetworks.AzureCloud.Public,
string? service = null,
string? region = null)
=> builder.RequireAzureIPNetworks(AzureIPNetworks.AzureIPsProvider.Local, cloud, service, region);

/// <summary>
/// Adds an <see cref="ApprovedIPNetworkRequirement"/> to the current instance, using known Azure IPs from an instance of <see cref="AzureIPNetworks.AzureIPsProvider"/>.
/// Ensure the necessary Authorization and framework services are added to the same collection
/// using <c>services.AddApprovedNetworksHandler(...)</c>.
/// Networks used are retrieved using <see cref="AzureIPNetworks.AzureIPsHelper"/>.
/// </summary>
/// <param name="builder">The instance to add to</param>
/// <param name="provider">The <see cref="AzureIPNetworks.AzureIPsProvider"/> to use.</param>
/// <param name="cloud">The Azure Cloud which to allow.</param>
/// <param name="service">
/// (Optional) The name of the service whose IP ranges to allow.
/// When not provided(null), IPs from all services are added.
/// </param>
/// <param name="region">
/// (Optional) The name of the region whose IP ranges to allow.
/// When not provided(null), IPs from all regions are added.
/// </param>
public static AuthorizationPolicyBuilder RequireAzureIPNetworks(this AuthorizationPolicyBuilder builder,
AzureIPNetworks.AzureIPsProvider provider,
AzureIPNetworks.AzureCloud cloud = AzureIPNetworks.AzureCloud.Public,
string? service = null,
string? region = null)
{
var networks = AzureIPNetworks.AzureIPsProvider.Local.GetNetworksAsync(cloud, service, region)
.AsTask()
.GetAwaiter()
.GetResult()
.ToArray();
var networks = provider.GetNetworksAsync(cloud, service, region)
.AsTask()
.GetAwaiter()
.GetResult()
.ToArray();

// create the requirement and add it to the builder
return builder.RequireApprovedNetworks(networks);
Expand Down