Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the checksums as a release artifact #168

Closed
rgl opened this issue Apr 26, 2023 · 0 comments · Fixed by #187
Closed

Include the checksums as a release artifact #168

rgl opened this issue Apr 26, 2023 · 0 comments · Fixed by #187

Comments

@rgl
Copy link

rgl commented Apr 26, 2023

Please include the checksums as a release artifact. This would make its usage easier.

Also, to make it easier to update the chart, it should be in a way that is compatible with the helm chart values.yaml declaration, or the chart values.yaml should be simplified to use the tarball checksum instead of the tarball content checksums.
@jacobweinstock jacobweinstock mentioned this issue Oct 5, 2023
Merged
3 tasks
jacobweinstock added a commit that referenced this issue Oct 6, 2023
@jacobweinstock
Add checksum file creation to releases: (#187)
facaebe 
## Description

<!--- Please describe what this PR is going to change -->
This makes it safer for users to consume Hook tarballs. Will also help
the user experience in the charts repo.

## Why is this needed

<!--- Link to issue you have raised -->

Fixes: #168 

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we
need?

<!--- Fixes a bug, unblocks installation, removes a component of the
stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checksum file creation to releases: jacobweinstock/hook
1 participant
@rgl