Add iPXE autoboot retries: #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 5 5
Lines 367 367
=======================================
Hits 359 359
Misses 4 4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
chrisdoherty4
approved these changes
Apr 23, 2024
|
Hey @nshalman , if you get some cycles I wanted to get your feedback here. Thanks, much appreciated! |
jacobweinstock
force-pushed
the
retry-autoboot
branch
from
60c4894
to
7fb68c8
Compare
Sometimes there are issues in iPXE or the network that retries can resolve. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
retry-autoboot
branch
from
7fb68c8
to
8aa5c20
Compare
|
whoops, duplicate of #87. Closing. |
Does it make sense to document the reason that retry logic is not implemented somewhere so that we don't find ourselves thinking about adding it every N months? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes there are issues in iPXE or the network that retries can resolve.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: