simplify the stand-up of a sandbox #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
one-touch-sandbox
branch
from
623c0f0
to
e3bc8fe
Compare
jacobweinstock
changed the title
jacobweinstock
force-pushed
the
one-touch-sandbox
branch
10 times, most recently
from
d07525f
to
4ad7340
Compare
jacobweinstock
force-pushed
the
one-touch-sandbox
branch
from
4ad7340
to
5fa17f1
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
I see two unnamed volumes in /var/lib/docker/volumes, both with contents that show it's from (And sorry for all the spammy messages with my train of thoughts spelled out, even though it's mostly out of scope for your PR :P) |
This was referenced Aug 24, 2021
By using `/usr/bin/env sh` I needed to ignore some shell checks. By moving to bash, those shell checks can be re-enabled. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This guide gives important details on the design and architecture of the stack stand up. This details all single run container/services and their purposes. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
one-touch-sandbox
branch
from
a25dd40
to
c256660
Compare
This makes switching between osie and hook via the .env file not cause the docker-compose up to error out. Creates a nicer experience when switching. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
one-touch-sandbox
branch
from
c256660
to
699a601
Compare
jacobweinstock
removed request for
nshalman,
tstromberg,
displague,
thebsdbox and
jeremytanner
This was referenced Aug 27, 2021
Closed
3 tasks
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
simplify the stand-up of a sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the stand-up of a sandbox. This PR has Vagrant Virtualbox, Vagrant Libvirt, Terraform Equinix Metal, and Docker Compose setups. This refactor modularizes the Tinkerbell stack to use docker-compose as the entry point and makes the creation of infrastructure on different providers the consumers of the docker-compose. Vagrant and Terraform are now only responsible for standing up infrastructure and then running docker-compose, not for running any glue scripts. The compose calls single-shot services to do all the glue required to get a fully functional Tinkerbell stack. All the single-shot services were made to be as idempotent as possible.
This increases portability and the speed of the development iteration cycle. This also simplifies the required steps needed to get a fully functioning sandbox up and running. All of the quick start guides are about 6-7 steps each.
This refactor aims to help people looking to get started by getting them to a provisioned machine quicker and more easily.
With the recent update in Hook to publish the kernel and initrd, this PR makes Hook the default OSIE. The Original OSIE can still be used. This is accomplished by updating the deploy/compose/.env and setting
OSIE_DOWNLOAD_URLto an OSIE URL andTINKERBELL_USE_HOOKto false. Currently only an x86_64 Hook is published so only x86_64 machines can be provisioned with the sandbox using Hook.Rendered QuickStart guide: https://github.com/jacobweinstock/sandbox/blob/one-touch-sandbox/README.md
Why is this needed
The existing setup.sh and genenv.sh and other glue scripts are outside of the the docker-compose and as such depend on the environment and require understanding to run successfully. This PR makes the stand up much simpler by only requiring
docker-compose up. This will help people looking to get started by getting them to a provisioned machine quicker and more easily.Fixes: #74, #85
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: