Remove discover of podcidrs: #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
changed the title
jacobweinstock
force-pushed
the
auto-discover-trusted-proxies
branch
from
f8041e4
to
d7164c2
Compare
The permissions needed to list nodes and pods in the "kube-system" namespace are too extensive and unneeded by Smee. Also not a good security posture to make these permissions available to Smee. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
auto-discover-trusted-proxies
branch
from
d7164c2
to
dc5b92d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
===================================
- Coverage 30% 28% -3%
===================================
Files 5 5
Lines 526 481 -45
===================================
- Hits 161 136 -25
+ Misses 353 337 -16
+ Partials 12 8 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The permissions needed to list nodes and pods in the "kube-system" namespace are too extensive and unneeded by Smee. Also not a good security posture to make these permissions available to Smee.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: