Skip to content

MyPy type checks #39

Closed
3 tasks done
iKintosh opened this issue Sep 14, 2021 · 0 comments · Fixed by #86
Closed
3 tasks done

MyPy type checks #39

iKintosh opened this issue Sep 14, 2021 · 0 comments · Fixed by #86
Assignees
@iKintosh
Labels
enhancement New feature or request

Comments

@iKintosh
Copy link
Contributor

🚀 Feature Request

Add Mypy type checks as a CI step.

Motivation

Usually developers forget to add types to their code, however types help while writing code and make code maintainable.

Proposal

Add Mypy type check as CI step.

Test cases

No need

Alternatives

  1. Manual type checking
  2. flake8-plugin annotation checking

Checklist

  • feature proposal description
  • motivation
  • extra proposal context / proposal alternatives review
@iKintosh iKintosh added enhancement New feature or request help wanted Extra attention is needed labels Sep 14, 2021
@iKintosh iKintosh self-assigned this Sep 14, 2021
@iKintosh iKintosh removed the help wanted Extra attention is needed label Sep 14, 2021
@iKintosh iKintosh mentioned this issue Sep 14, 2021
Closed
13 tasks
@iKintosh iKintosh linked a pull request Sep 14, 2021 that will close this issue
add mypy to core, model, transforms and datasets modules #48
Closed
13 tasks
@iKintosh iKintosh mentioned this issue Sep 23, 2021
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iKintosh iKintosh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@iKintosh