Skip to content

Make to_dataset method work with copy #741

Closed
1 task
alex-hse-repository opened this issue Jun 8, 2022 · 0 comments · Fixed by #744
Closed
1 task

Make to_dataset method work with copy #741

alex-hse-repository opened this issue Jun 8, 2022 · 0 comments · Fixed by #744
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Jun 8, 2022

🚀 Feature Request

Make TSDataset method to_dataset work with copy of the passed dataframe

Motivation

Some users argues that it is not obvious that to_dataset method modify the dataframe inside

Proposal

Now to_dataset method should work with copy of the dataframe

Test cases

  • In tests/test_dataset/test_dataset.py create test test_to_dataset_not_modify_dataframe
  • Use some fixture as an input of the to_dataset method and make sure it does not modify the passed dataframe

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Jun 8, 2022
@alex-hse-repository alex-hse-repository moved this to Specification in etna board Jun 8, 2022
@alex-hse-repository alex-hse-repository added the good first issue Good for newcomers label Jun 8, 2022
@alex-hse-repository alex-hse-repository changed the title Make TSDataset methods work with copies Make to_dataset method work with copies Jun 8, 2022
@alex-hse-repository alex-hse-repository changed the title Make to_dataset method work with copies Make to_dataset method work with copy Jun 8, 2022
@alex-hse-repository alex-hse-repository moved this from Specification to Todo in etna board Jun 8, 2022
martins0n added a commit that referenced this issue Jun 14, 2022
Co-authored-by: Martin Gabdushev <33594071+martins0n@users.noreply.github.com>
Repository owner moved this from Todo to Done in etna board Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant