Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a relative mouse. #1415

Closed
wants to merge 1 commit into from

Conversation

A2Wolverin3
Copy link

@A2Wolverin3 A2Wolverin3 commented May 30, 2023

Adds support for a relative mouse.

I needed this for my NVR which doesn't recognize absolute position pointer. This adds new menu item in the 'View' menu which lets users enter a pointerlock-ed "relative" mouse mode. This mode must be exited with the Escape key.

Fixes #853

Review on CodeApprove

@mtlynch
Copy link
Contributor

mtlynch commented May 30, 2023

This is great! Thanks for contributing this. You did a great job of matching our conventions around style and testing.

This is a pretty big feature, and it's going to require some iterations on architecting the different pieces of it and adjusting the web UI. Honestly, it is going to be a significant amount of work, so I don't want you to feel obligated to go through that process with us, but I also don't want to cut you out of the process if you want to do that heavy lifting.

Would you prefer we take the PR from here and iterate on it internally? Or would you prefer that we give you feedback what architecture and UI changes we'd need to see?

@A2Wolverin3
Copy link
Author

You can go ahead and iterate without me. To be honest, I'm mostly just trying to get this working in my smarthome setup where I've got my NVR tucked away in a not-very-accessible place. But my cheap NVR is particular and needed a relative mouse. (And annoyingly, the absence of an absolute mouse.) I knew this was an item on the list, so I figured I'd give it a go and send it in.

I'm also docker-izing things for my setup. (I can send a PR for that as well if you like, but I gather from reading past issues and questions that docker isn't something that's quite on your roadmap for this project.) And since I'm pretty sure the general audience isn't looking to run with my custom smarthome configuration, I'll probably be pulling and running from my own fork anyway. 😉

@mtlynch
Copy link
Contributor

mtlynch commented May 31, 2023

Okay, cool.

I'm going to close this PR for now, but I've prioritized the feature for our next sprint.

@mtlynch mtlynch closed this May 31, 2023
@mtlynch
Copy link
Contributor

mtlynch commented May 31, 2023

Oh, forgot to respond to this part:

I'm also docker-izing things for my setup. (I can send a PR for that as well if you like, but I gather from reading past issues and questions that docker isn't something that's quite on your roadmap for this project.) And since I'm pretty sure the general audience isn't looking to run with my custom smarthome configuration, I'll probably be pulling and running from my own fork anyway.

Yeah, there was some prior work around Docker in #403 but we're not planning to adopt Docker for the foreseeable future. Our worry is that by adding another layer of abstraction, it's an extra step in debugging to figure out if it's an inherent bug or a consequence of our Docker packaging.

I really like Docker, but for this project, we've already spent our complexity budget elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support relative mouse mode
2 participants