Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8720dn: add Rpc_tcpip_adapter_init_with_timeout() #445

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sago35
Copy link
Member

@sago35 sago35 commented Aug 1, 2022

For example, if the firmware of the RTL8720 is out of date, no response will be returned.
This PR defines functions that can time out in such cases.

The reason for not updating Rpc_tcpip_adapter_init directly is that Rpc_tcpip_adapter_init is automatically generated.

@scottfeldman
Copy link
Contributor

An alternative to this PR would be to check the fw version before calling tcpip_adapter_init(), and error out if fw version is too old. I confirmed we can get fw version before calling tcpip_adapter_init(). Current fw version I have on my wioterminal is:

RTL8720 firmware version : 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants