Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: implement readdir for darwin and linux #2499

Merged
merged 2 commits into from
Feb 2, 2022
Merged

os: implement readdir for darwin and linux #2499

merged 2 commits into from
Feb 2, 2022

Commits on Jan 26, 2022

  1. os: implement readdir for darwin and linux 

    readdir is disabled on linux for 386 and arm until syscall.seek is implemented there.

windows is hard, so leaving that for later.

File src/os/dir_other_go115.go can be deleted when we drop support for go 1.15.

Also adds TestReadNonDir, which was helpful while debugging.
    @dkegel-fastly
    dkegel-fastly committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    16cb8b5 View commit details
    Browse the repository at this point in the history

  2. os: add DirFS, which is used by many programs to access readdir. 

    It's wafer-thin :-)

Includes smoke test from upstream.

TODO: once t.TempDir is implemented, add io/fs to the list of standard library tests to run; that's a better test.
    @dkegel-fastly
    dkegel-fastly committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    e9fd684 View commit details
    Browse the repository at this point in the history