Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "all: move stm32 files to separate repository" #2654

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

sago35
Copy link
Member

@sago35 sago35 commented Feb 25, 2022

This PR is to revert #2634.

Since the problem is reproduced in the local environment, I think it is better to revert and then PR again after the countermeasure is completed.
More information about the problem can be found below.

tinygo-org/drivers#379

@sago35
Copy link
Member Author

sago35 commented Feb 26, 2022

Whenever someone does CI using tinygo/tinygo-dev, it always results in an error.
This is a very bad problem.

@deadprogram
Copy link
Member

Agreed. Reverting is the best option for now.

@deadprogram deadprogram merged commit d65e3de into dev Feb 28, 2022
@deadprogram deadprogram deleted the revert-stm32 branch February 28, 2022 09:19
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to say LGTM. I (or somebody else!) need to investigate how to implement this properly. I probably should have marked #2634 as draft to avoid this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants