cgo: refactor #2774
Merged
cgo: refactor #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a large refactor of the cgo package. It should fix a number of smaller problems and be a bit more strict (like upstream CGo): it for example requires every Go file in a package to include the header files it needs instead of piggybacking on imports in earlier files. The main benefit is that it should be a bit more maintainable and easier to add new features in the future (like static functions). This breaks the tinygo.org/x/bluetooth package, which should be updated before this change lands.
aykevl
added a commit
to tinygo-org/bluetooth
that referenced
this pull request
Apr 13, 2022
For details, see: tinygo-org/tinygo#2774
|
This PR changes the internal structure of the cgo package:
|
deadprogram
pushed a commit
to tinygo-org/bluetooth
that referenced
this pull request
Apr 13, 2022
For details, see: tinygo-org/tinygo#2774
💯 |
You do not exaggerate. I am still digesting it, but so far I like what I see. |
|
I suspect a change may be needed for https://github.com/tinygo-org/tinyfs |
Didn't test it, but yes there's a good chance that package needs an update. |
|
Seems like tinyfs is still working as expected even with this refactor. I think we should merge unless for some reason we want to hold until after next release. |
|
Let's merge this now. Thanks @aykevl for the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large refactor of the cgo package. It should fix a number of smaller problems and be a bit more strict (like upstream CGo): it for example requires every Go file in a package to include the header files it needs instead of piggybacking on imports in earlier files.
The main benefit is that it should be a bit more maintainable and easier to add new features in the future (like static functions).
This breaks the tinygo.org/x/bluetooth package (tinygo-org/bluetooth#97), which should be updated before this change lands.