-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rp2040: fix errata RP2040-E5 issue #2991
Conversation
As noted in the comments below, the code in this PR is probably working correctly.
|
RP2040-E5 fix ready for review. |
@sago35 just wondering if we should be checking the chip version for this fix, similar to https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_fix/rp2040_usb_device_enumeration/rp2040_usb_device_enumeration.c#L27 |
@deadprogram version check added. I checked pico (B0 chip)
pico-w (B2 chip)
test code
The const values were described below. SYSINFO_CHIP_ID_OFFSET SYSINFO_CHIP_ID_REVISION_BITS SYSINFO_CHIP_ID_REVISION_LSB |
Sometimes machine_rp2040_enter_bootloader.go fails. https://github.com/tinygo-org/tinygo/blob/rp2040-e5/src/machine/machine_rp2040_enter_bootloader.go
|
@sago35 that is one of the occasional errors that only occur in the Windows smoke tests. Something is not quite correct, but not sure it can be attributed to the place the error appears. However, not sure on that one. |
Thanks for making the requested changes @sago35 now merging. |
https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_fix/rp2040_usb_device_enumeration/rp2040_usb_device_enumeration.c