Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: disable parallelism on Windows #3525

Merged
merged 1 commit into from
Mar 6, 2023
Merged

windows: disable parallelism on Windows #3525

merged 1 commit into from
Mar 6, 2023

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Mar 6, 2023

This is an attempt to figure out why the Windows CI keeps crashing. It should be removed before the next release, by which point we should know whether this has helped or not.

You might say I'm getting desperate looking for solutions.

@aykevl
windows: disable parallelism on Windows
7fadfe8 
This is an attempt to figure out why the Windows CI keeps crashing. It
should be removed before the next release, by which point we should know
whether this has helped or not.
deadprogram
deadprogram approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@deadprogram deadprogram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this worked. There is a separate issue with Windows CI and the std tests for the net package, but that is I think unrelated.

Maybe we should put this behind a flag, if we are unable to resolve otherwise before the next release.

@deadprogram
Copy link
Member

Merging to get the build back.

@deadprogram deadprogram merged commit 192a559 into dev Mar 6, 2023
@deadprogram deadprogram deleted the windows-gomaxprocs branch March 6, 2023 17:48
@deadprogram
Copy link
Member 

--- FAIL: TestCompiler (10.04s)
    --- FAIL: TestCompiler/goroutine.go-cortex-m-qemu-tasks (0.7[9](https://github.com/tinygo-org/tinygo/actions/runs/4346376523/jobs/7592354126#step:16:10)s)
Error:         compiler_test.go:112: could not parse test case goroutine.go: could not compile: <cgo>:1:1: error: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely
FAIL
FAIL	github.com/tinygo-org/tinygo/compiler	[10](https://github.com/tinygo-org/tinygo/actions/runs/4346376523/jobs/7592354126#step:16:11).249s

https://github.com/tinygo-org/tinygo/actions/runs/4346376523/jobs/7592354126#step:16:11

@aykevl
Copy link
Member Author

aykevl commented Mar 6, 2023

Hmm, that seems bad.

Maybe leave it in at least a few days so we can get a better feel whether anything changed at all?

@deadprogram
Copy link
Member

Let's let it run for a bit and see.

@deadprogram deadprogram mentioned this pull request Mar 7, 2023
Merged
aykevl added a commit that referenced this pull request May 13, 2023
@aykevl
windows: re-enable parallelism
9d89f79 
This reverts #3525, because
that change didn't seem to stop the CI failures we have been seeing.
Instead, I've added thread support in
#3130 which IIRC fixed most of
the CI crashes.

Re-enabling parallelism should improve the performance of TinyGo a bit
on Windows.
@aykevl aykevl mentioned this pull request May 13, 2023
Merged
deadprogram pushed a commit that referenced this pull request May 16, 2023
@aykevl @deadprogram
windows: re-enable parallelism
af76c80 
This reverts #3525, because
that change didn't seem to stop the CI failures we have been seeing.
Instead, I've added thread support in
#3130 which IIRC fixed most of
the CI crashes.

Re-enabling parallelism should improve the performance of TinyGo a bit
on Windows.
LiuJiazheng pushed a commit to LiuJiazheng/tinygo that referenced this pull request Aug 20, 2023
@aykevl @LiuJiazheng
windows: re-enable parallelism
92c5bca 
This reverts tinygo-org#3525, because
that change didn't seem to stop the CI failures we have been seeing.
Instead, I've added thread support in
tinygo-org#3130 which IIRC fixed most of
the CI crashes.

Re-enabling parallelism should improve the performance of TinyGo a bit
on Windows.
deadprogram pushed a commit that referenced this pull request Sep 17, 2023
@aykevl @deadprogram
windows: re-enable parallelism
27be11d 
This reverts #3525, because
that change didn't seem to stop the CI failures we have been seeing.
Instead, I've added thread support in
#3130 which IIRC fixed most of
the CI crashes.

Re-enabling parallelism should improve the performance of TinyGo a bit
on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadprogram deadprogram deadprogram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aykevl @deadprogram