Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNUmakefile: add some more passing stdlib tests #4492

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

dgryski
Copy link
Member

@dgryski dgryski commented Oct 2, 2024

No description provided.

@dgryski
Copy link
Member Author

dgryski commented Oct 2, 2024

Just realized this is mostly duplicating #4433 , which for some reason I thought was only adding a much smaller number of packages..

@aykevl
Copy link
Member

aykevl commented Oct 2, 2024

This fails on MacOS:

panic: runtime error at 0x0000000100f36ba0: goroutine stack overflow
FAIL	go/printer	0.199s

Kinda surprised by that one, perhaps it has some test for the maximum stack depth or something?

These fail on Windows:

FAIL	debug/dwarf	0.626s
--- FAIL: Test (0.00s)
    no testdata
    FailNow is incomplete, requires runtime.Goexit()
FAIL
FAIL	internal/diff	0.058s

@dgryski dgryski force-pushed the dgryski/more-stdlib-tests2 branch 2 times, most recently from 4dd6ca1 to d52fbca Compare October 2, 2024 22:55
@dgryski
Copy link
Member Author

dgryski commented Oct 3, 2024

Removed some packages and now everything is green. If we merge this we can update dev with whatever is left-over from your PR.

@dgryski dgryski force-pushed the dgryski/more-stdlib-tests2 branch 2 times, most recently from cd88f38 to 3a38354 Compare October 3, 2024 20:26
@dgryski dgryski merged commit e17daf1 into tinygo-org:dev Oct 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants