Refactor origin handler #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type-check the `origin` parameter to `cors` when `cors` is invoked, rather than when requests are handled by its returned middleware.
|
I've missed a case here - when |
the JetBrains git integration uses a non-login non-interactive shell to execute Git commands, which means `pnpm` cannot be found the `-l` option means a login shell is used, so `~/.bashrc` is used as a startup file, which adds `$PNPM_HOME` to `$PATH`
talentlessguy
requested changes
Jun 30, 2024
Pull Request Test Coverage Report for Build 9908624002Details
💛 - Coveralls |
|
Dismiss the report, coverage report was broken The bug fix is published in 2.0.1, thanks a lot for fixing https://github.com/tinyhttp/cors/releases/tag/v2.0.1 Coverage is 93% |
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4