fix: allow empty json body #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json middleware crashes when it receives an empty string from req.chunk This causes JSON.parse() to throw an exception since it does not accept empty strings
fargito
reviewed
Feb 24, 2023
| }) | ||
|
|
||
| await makeFetch(server)('/', { | ||
| body: '', |
There was a problem hiding this comment.
Maybe you could also test the case where no body is set at all. In think your code handles it as well.
There was a problem hiding this comment.
Hey, took me long to recheck this PR but I included the other test case too
Added a check for unset body on the test "should ignore JSON empty body"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json middleware crashes when it receives an empty string from req.chunk.
This causes JSON.parse() to throw an exception since it does not accept empty strings.