Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type lowering and map[string]ArbitraryType #10

Merged
merged 10 commits into from
Sep 24, 2014
Merged

Type lowering and map[string]ArbitraryType #10

merged 10 commits into from
Sep 24, 2014

Conversation

philhofer
Copy link
Member

Identifier resolution is a pain in the butt.

In any case, the following is now supported

type MyInt int
type Thing struct {
    Which map[string]MyInt `msg:"which_counts"`
}

At the moment we only do lowering for "base" built-ins (int, float64, string, and, as a special case, []byte. Maps and slices are unsupported.) Custom composite types (like type MyFloats []float64) are not yet supported.

Also, there's a bug fix for reading pointers ahead.

@philhofer
Copy link
Member Author

Improves #2 and fixes #3

@philhofer
Copy link
Member Author

As a bonus, c7d5839 has the groundwork for #9.

philhofer added a commit that referenced this pull request Sep 24, 2014
Type lowering and map[string]ArbitraryType - fixes #3
@philhofer philhofer merged commit a266ef5 into master Sep 24, 2014
@philhofer philhofer mentioned this pull request Oct 19, 2014
@philhofer philhofer deleted the ident branch November 17, 2014 19:04
zeldovich added a commit to zeldovich/msgp that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant