Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run goimports everywhere, in parallel #90

Merged
merged 2 commits into from
Jun 6, 2015
Merged

Run goimports everywhere, in parallel #90

merged 2 commits into from
Jun 6, 2015

Conversation

philhofer
Copy link
Member

Three changes:

  • Runs goimports on the generated test code
  • Runs goimports in parallel on both generated files
  • The intermediate (un-formatted) code is written to a buffer rather than to disk. It doesn't make sense to write data to disk if we're just going to read it out again to run goimports.

Review on Reviewable

@philhofer philhofer mentioned this pull request Jun 6, 2015
Closed
@philhofer philhofer changed the title Raw print Run goimports everywhere, in parallel Jun 6, 2015
philhofer added a commit that referenced this pull request Jun 6, 2015
@philhofer
Merge pull request #90 from tinylib/raw-print
9d2043d 
run goimports everywhere, in parallel; don't write intermediate code to disk
@philhofer philhofer merged commit 9d2043d into master Jun 6, 2015
@philhofer philhofer mentioned this pull request Jun 6, 2015
Closed
@philhofer philhofer mentioned this pull request Mar 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philhofer