fix: prevent new workers from writing to closed pool #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AriPerkkio
commented
May 22, 2024
•
AriPerkkio
commented
- Fixes ERR_IPC_CHANNEL_CLOSED: Channel closed #94
AriPerkkio
force-pushed
the
fix/process-workers-closing-pool
branch
from
cb7ce9f
to
3f11d7b
Compare
AriPerkkio
force-pushed
the
fix/process-workers-closing-pool
branch
from
3f11d7b
to
5796e7a
Compare
AriPerkkio
commented
May 25, 2024
Comment on lines
+42
to
+51
| send!( | ||
| <OutgoingMessage>{ | ||
| ready: true, | ||
| source: 'pool', | ||
| __tinypool_worker_message__: true, | ||
| }, | ||
| () => { | ||
| // Ignore errors coming from closed channel | ||
| } | ||
| ) |
There was a problem hiding this comment.
Another approach is to check process.channel here. Though now new Error: write EPIPE errors come up randomly when pool is closing. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.