TINY-9428: Code Scanning #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spocke
requested review from
TheSpyder,
ephox-mogran,
a team,
yacodes,
vpyshnenko and
HAFRMO
and removed request for
a team
yacodes
approved these changes
Nov 30, 2022
ephox-mogran
approved these changes
Nov 30, 2022
|
This was failing on CI due to it now running node 18 and gulp-typescript is not compatible with that due to it using an older version of source-maps and other dependencies. But that package is no longer maintained and couldn't find any alternatives so I just forced the dependencies to be later versions using the "resolutions" field for now. There is a PR open that no one has bothered with: ivogabe/gulp-typescript#670 this probably needs further investigation if we want to support this properly in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-9428
Description of Changes: