Make tinet build (buildfile option) work
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we set "buildfile: Dockerfile" and "image: foo:latest" node options, `tinet build` produces following command. docker build -t foo:latest Dockerfile There are several missing stuff in here. First it needs -f option to specify Dockerfile path. And second, it doesn't have build context (e.g. .). Overall, the correct command should look like this. docker build -t foo:latest -f Dockerfile . First issue can be solved by adding missing -f option. However, for the second issue, we don't have any way to specify build context in current manifest. Thus, this commit adds new node option "buildcontext" as well. Signed-off-by: Yutaro Hayakawa <yhayakawa3720@gmail.com>
slankdev
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we set "buildfile: Dockerfile" and "image: foo:latest"
node options,
tinet buildproduces following command.docker build -t foo:latest Dockerfile
There are several missing stuff in here. First it needs -f option to
specify Dockerfile path. And second, it doesn't have build context (e.g.
.). Overall, the correct command should look like this.
docker build -t foo:latest -f Dockerfile .
First issue can be solved by adding missing -f option. However, for the
second issue, we don't have any way to specify build context in current
manifest. Thus, this commit adds new node option "buildcontext" as well.
Signed-off-by: Yutaro Hayakawa yhayakawa3720@gmail.com