Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume existing sessions in new tabs and after browser refresh #8

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

tinyzimmer
Copy link
Collaborator

Fixes #7

Gonna sit on it for a little longer to make sure I like it and to see if any input comes from the webosphere

…whoami request, populate local session store from those retrieved when renewing session
@nikhiljha
Copy link

Oh neat! What's the easiest way to test this? docker build -> set manager.image in the Helm chart?

Although it looks like GitHub is building something so I could just wait for that :P

@tinyzimmer
Copy link
Collaborator Author

tinyzimmer commented Dec 11, 2020

@nikhiljha I actually don't have it set to publish pull request images. If you want to test it right away, all the changes are in the app image. I'll probably merge to master later today which will produce a latest tag. Might just go ahead and bump the release also when I do that which will make a v0.1.1.

The easiest way to build that is to check out this branch and run make build-app. It's a bit of a convoluted multistage build in an effort to make it quicker to iterate on when developing. Then you just need to patch the VDICluster object. If you used the defaults in that space when installing it'd probably be a blank string like below (which defaults to the same version as the manager).

$ kubectl get vdicluster kvdi -o json | jq .spec.app.image
""

Just set that field to point to the image you built. You can do it with a helm arg too, I'd have to double check my docs 😛 but I think it's just --set vdi.spec.app.image=my/image

@tinyzimmer tinyzimmer merged commit 4ba3d41 into main Dec 11, 2020
@tinyzimmer tinyzimmer deleted the bugfix/sessions-dissapear-on-tab-reload branch December 11, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

closing a tab with a kvdi session in it makes it disappear
2 participants