This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Instead of matching exception class simple names to an error codes I've updated the code to match the exception class to the error codes.
The issue we discovered was that ProGuard would obfuscate the class simple names. This would cause the error code lookup table to always miss and throw a NullPointerException.
An alternative solution would have been to adjust our ProGuard rules to prevent obfuscating. While this would fix the issue this wouldn't help anybody else running into this.
Additionally, I didn't like that when the lookup table missed a non-descript NullPointerException would be thrown. I've updated that to simply rethrow the error so that crash logs will at least have the root cause error rather than the non-descript NullPointerException.
Types of changes
Checklist