New json api #3
Merged
New json api #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out OE1Client.get_item_url() and remove url from item dict. This improves performance significantly since determining the url of each item requires an HTTP request.
|
Fixes Bug #2. |
|
Thanks for the PR, sorry I had to let you wait for so long. I also noticed that the new API returns metadata of future broadcasts. Because time travel is still a bit complicated, those get filtered out for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits make the plugin work again with the new JSON API that is used by Ö1. Another commit improves performance significantly by not building the track URLs when listing the items, since this requires an HTTP request for each item.