Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc Browser: Insert doesn't work from "Select Translate" #622

Closed
5 of 6 tasks
simonbcn opened this issue Jul 28, 2024 · 25 comments
Closed
5 of 6 tasks

Arc Browser: Insert doesn't work from "Select Translate" #622

simonbcn opened this issue Jul 28, 2024 · 25 comments
Assignees
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@simonbcn
Copy link

Please confirm the following:

  • Be sure to check out FAQ
  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Problem description

Arc Browser.
When I select text within an input field and press the icon or key combination for "Select Translate", the mini-window with the translation opens and there is a button that allows me to replace the selected text with the translation but it does nothing.

Is the issue consistently reproducible?

Reproducible

Steps to Reproduce

Arc Browser.
When I select text within an input field and press the icon or key combination for "Select Translate", the mini-window with the translation opens and there is a button that allows me to replace the selected text with the translation but it does nothing.

Screenshot

Captura de pantalla 2024-07-28 a las 9 19 35

Expected result

It should replace the selected text with the translation.

Proposed solution (optional)

No response

Device type and OS version

macOS 14.5

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR
@simonbcn simonbcn added the bug Something isn't working label Jul 28, 2024
Copy link

Hello simonbcn, Thank you for your first issue contribution 🎉

@tisfeng
Copy link
Owner

tisfeng commented Jul 28, 2024

I'm not using Arc Browser, @Jerry23011 can you help look at this?

@Jerry23011
Copy link
Collaborator

I can reproduce the issue.
e.g. On google.com, input “test” in the search field, then select text, and replace with translated text. Works on Safari but not Arc

@tisfeng
Copy link
Owner

tisfeng commented Jul 29, 2024

Arc Browser behaves strangely, it may not support Accessibility, I will try to fix it later 😓

@tisfeng tisfeng self-assigned this Jul 29, 2024
@simonbcn
Copy link
Author

Arc Browser is based on Chromium, like most current browsers.

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Jul 30, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jul 30, 2024

I tested and found that using the Accessibility method to replace translations on Arc Browser returns successful results, but the actual replacement operation fails, which is strange. It behaves differently from Chrome in some ways.

I added an option to ensure that replacement is successful on Arc Browser #624 .

@tisfeng
Copy link
Owner

tisfeng commented Aug 12, 2024

Version 2.8.0 has fixed this issue.

@tisfeng tisfeng closed this as completed Aug 12, 2024
@simonbcn
Copy link
Author

It still fails.

@Jerry23011
Copy link
Collaborator

Turn on Replace translation with compatibility mode in advanced settings @simonbcn

@simonbcn
Copy link
Author

It doesn't work either. Paste the content into the easydict application window:

Captura de pantalla 2024-08-17 a las 9 18 45

@Jerry23011
Copy link
Collaborator

Could you give me the website that didn’t work for you?

@simonbcn
Copy link
Author

This: github.

@Jerry23011
Copy link
Collaborator

It works for me. Could you upload a screen recording to reproduce the issue? Thanks

2024-08-17.15.52.34.mov

@simonbcn
Copy link
Author

Grabacion.de.pantalla.2024-08-17.a.las.10.13.39.mp4

@Jerry23011
Copy link
Collaborator

Jerry23011 commented Aug 17, 2024

CC @tisfeng Not sure what's going on here. I can't reproduce the issue with the exact same operations.

@simonbcn Meanwhile, I suggest uninstalling Easydict completely (including the cache, config files, and permission settings) and reinstall it to see if the issue persists. This is to see if the issue happens due to an environment variable on your local macOS.

@tisfeng
Copy link
Owner

tisfeng commented Aug 17, 2024

@simonbcn First, make sure you have the "Use Replace with Translation in compatibility mode" option turned on.

Also, could you please provide the Easydict log zip file(menu icon -> Help -> Export log) and we'll check it out.

99367

@tisfeng
Copy link
Owner

tisfeng commented Aug 17, 2024

I watched the video carefully and noticed a strange point: after clicking the replace button, the Easydict window should be hidden automatically (this is very important), just like shown in @Jerry23011's video.

@simonbcn I'm not sure why your window didn't hide; can you check it?

@simonbcn
Copy link
Author

I have uninstalled the application with CleanMyMac. I have done a search on the disk for "easydict" and I have deleted the folders/files that had that name. I have restarted the system and reinstalled the application, now it works correctly.

@Jerry23011
Copy link
Collaborator

Great to hear that! This could be caused by a data race error where user data is corrupted. We might want to migrate the project to Swift 6 in the future to prevent that.

@MilchstraB
Copy link

I found that I had to turn on the forced word option to successfully open the translation button in Arc browser.

@tisfeng
Copy link
Owner

tisfeng commented Aug 20, 2024

No, testing on my computer, Arc supports Accessibility to obtain selected text, which means that it can work without enabling forced word retrieval.

I rarely use Arc and am not familiar with it, so I'm not sure if there is a problem with Arc, because I found that some of its behaviors are different from Chrome, for example, #622 (comment).

@MilchstraB
Copy link

Thanks for your reply! My question is shown in the video. The machine I used was the M2 Macbook Air with MacOS 14.6.1, Arc Browser 1.56.0 and Easydict 2.8.1.

2024-08-20.22.22.36.mp4

@Jerry23011
Copy link
Collaborator

Jerry23011 commented Aug 20, 2024

Very interesting. It works on my end as well without enabling force get text.

@MilchstraB How about try resetting your Easydict Accessibility permissions.

I'm on macOS 14.6.1 | Easydict 2.8.1 | Arc 1.56.0

2024-08-20.22.36.50.mov

@MilchstraB
Copy link

It's very interesting. I tried to reinstall the APP and reset the permissions for word translation, and only the button that turns on the forced text selection seemed to work for me. If this option is not turned on, text cannot be correctly selected in the sidebar even if the shortcut option + D is used. However, it has little effect on use.

@tisfeng
Copy link
Owner

tisfeng commented Aug 22, 2024

@MilchstraB You can upload the Easydict zip runtime log. It might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

4 participants