Fix comparison of Float with String failed when WD_CACHE_TIME is set #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArgumentError: comparison of Float with String failed /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/system.rb:48:in `<' /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/system.rb:48:in `valid_cache?' /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/common.rb:153:in `with_cache' /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/chromedriver.rb:34:in `latest_version' /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/common.rb:127:in `correct_binary?' /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/common.rb:83:in `update' /home/runner/dossier/vendor/bundle/ruby/2.4.0/gems/webdrivers-4.0.0.rc1/lib/webdrivers/tasks/chromedriver.rake:25
|
Hi @jmgarnier, thanks for the pull request. I thought I had caught and fixed this in my PR, but apparently not. Anyway, I have fixed this under 10a5bee and added a spec for it. We'll release a |
|
And sorry, didn't mean to take credit away from your contribution. I just found a better spot to implement the fix and wanted to add a spec for it. I appreciate you reporting this! |
|
thanks for all the kind words @kapoorlakshya . No offenses, no credit needed! Thanks for quick feedback & sharing your work for free :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command
bundle exec rake webdrivers:chromedriver:update WD_CACHE_TIME=86_400 WD_INSTALL_DIR=$SEMAPHORE_CACHE_DIRstacktrace