Chromedriver#latest_version now returns latest binary version corresponding to the installed Chrome version. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2019
kapoorlakshya
force-pushed
the
feature/download-chromedriver-by-chrome-version
branch
2 times, most recently
from
eba6ace
to
404ba5d
Compare
|
Alright! Specs now pass on all three - Windows, Linux, and OSX. |
jkotests
reviewed
Mar 18, 2019
kapoorlakshya
force-pushed
the
feature/download-chromedriver-by-chrome-version
branch
from
8f59d9e
to
a9b728a
Compare
|
Ugh. This is another example of me walking through my code wondering "who the hell wrote this crap?" |
titusfortner
requested changes
Mar 19, 2019
…e installed Chrome version.
kapoorlakshya
force-pushed
the
feature/download-chromedriver-by-chrome-version
branch
from
a9b728a
to
ee698cb
Compare
kapoorlakshya
deleted the
feature/download-chromedriver-by-chrome-version
branch
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31 - Google now matches the
chromedriverversion to Chrome browser version (source). This PR updatesChromedriver#latest_versionto download the latest binary corresponding to the installed Chrome (major) version.Without this change, the gem fetches
chromedriverversion 2.46 as the latest one regardless of your Chrome version.Example
If you have Chrome 72.0.3626.121 installed, the gem will now fetch the latest binary release for version 72.0, which is 72.0.3626.69.
Specs
Windows - Pass (local @ Windows 10)
Linux - Pass (Travis)
Mac - Pass (Travis)
Updated
travis.ymlto install Chrome, and to run specs on Linux and Mac..