Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with cloning o2o fields #252

Merged
merged 9 commits into from
Apr 7, 2021
Merged

Fixed bug with cloning o2o fields #252

merged 9 commits into from
Apr 7, 2021

Conversation

jackton1
Copy link
Member

@jackton1 jackton1 commented Apr 7, 2021

No description provided.

@pep8speaks
Copy link

pep8speaks commented Apr 7, 2021

Hello @jackton1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-07 18:15:06 UTC

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #252 (03f6748) into main (97f3e90) will increase coverage by 4.73%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   84.55%   89.28%   +4.73%     
==========================================
  Files           6        6              
  Lines         246      252       +6     
==========================================
+ Hits          208      225      +17     
+ Misses         38       27      -11     
Impacted Files Coverage Δ
model_clone/mixins/clone.py 84.27% <96.15%> (+3.89%) ⬆️
model_clone/utils.py 97.40% <100.00%> (+7.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f3e90...03f6748. Read the comment docs.

@jackton1 jackton1 linked an issue Apr 7, 2021 that may be closed by this pull request
@jackton1 jackton1 merged commit 342eca8 into main Apr 7, 2021
@jackton1 jackton1 deleted the fix-bug-with-o2o-fields branch April 7, 2021 18:19
jackton1 added a commit that referenced this pull request Apr 7, 2021
jackton1 added a commit that referenced this pull request Apr 7, 2021
@jackton1 jackton1 restored the fix-bug-with-o2o-fields branch April 7, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error cloning models that have one to one fields
2 participants