Make sure format string is properly translated #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we apply `format` to the string directly Django tries to translate the string including the actual name of the clone, but there won't be any translations for that. So instead we need to apply `format` on the translated string.
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 6 6
Lines 270 270
=======================================
Hits 260 260
Misses 10 10 Continue to review full report at Codecov.
|
|
Thanks @ptrck |
jackton1
approved these changes
Jun 2, 2021
|
@allcontributors add @ptrck for bugs |
|
I've put up a pull request to add @ptrck! 🎉 |
|
@allcontributors add @ptrck for code |
|
I've put up a pull request to add @ptrck! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a small bug in
admin.py:_("Duplication successful, redirected to cloned: {}".format(clone))In this case
formatis being applied to the string before translation and Django and tries to translate the string including the name of the clone, but ofc there won't be any translations for that. So instead we need to applyformaton the translated string:_("Duplication successful, redirected to cloned: {}").format(clone)