Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generator test #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix generator test #248

wants to merge 1 commit into from

Conversation

alsotang
Copy link

now, https://github.com/tj/co/blob/e679907d5e06b48e5d7523a856b75ca21eec8349/test/generators.js is the same as https://github.com/tj/co/blob/e679907d5e06b48e5d7523a856b75ca21eec8349/test/generator-functions.js .

work() would produce a generator, while work is a generator function. so I think we should explicit call work, avoiding it enter this condition:

co/index.js

Line 51 in e679907

if (typeof gen === 'function') gen = gen.apply(ctx, args);

then the test make sense

@alsotang
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant