-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated functionality #1349
Merged
Merged
Deprecated functionality #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Previously started in #1314 but that included undocumented features, which was somewhat a contradiction. 😄 ) |
shadowspawn
added
the
semver: major
Releasing requires a major version bump, not backwards compatible
label
Sep 8, 2020
This comment has been minimized.
This comment has been minimized.
shadowspawn
removed
the
semver: major
Releasing requires a major version bump, not backwards compatible
label
Sep 13, 2020
abetomo
approved these changes
Sep 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very easy to understand.
shadowspawn
added
the
pending release
Merged into a branch for a future release, but not released yet
label
Sep 26, 2020
shadowspawn
removed
the
pending release
Merged into a branch for a future release, but not released yet
label
Jan 16, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
We keep functionality around to avoid breaking backwards compatibility for as long as reasonable.
How should we talk about old functionality, especially that we might delete one day? How do people find out about the new/better ways of doing things?
The semver pattern is to explicitly deprecate functionality before it can be removed in a future major version. We can do this early, or just-in-time with a minor release to deprecate some functionality and then remove it immediately in the next major version.
Problem
Solution
Explicitly deprecate old functionality:
@deprecated
if possible for IDE feedback