Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getOptionValue and setOptionValue #1521

Merged
merged 7 commits into from May 18, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented May 16, 2021

Pull Request

(Note: this PR was branched from #1520 before that was merged, and first three commits are from that branch and actually already merged.)

Problem

Now we are not storing options as properties on command, there is not a public
way of setting option values. This may become more common with the new hooks.

Solution

Make the existing internal routines public and add tests et al

ChangeLog

  • add .getOptionValue() and .setOptionValue()

@shadowspawn shadowspawn added this to the v8.0.0 milestone May 16, 2021
@shadowspawn shadowspawn changed the title Add getAccessValue and setAccessValue Add getOptionValue and setOptionValue May 16, 2021
@shadowspawn shadowspawn marked this pull request as ready for review May 17, 2021
Copy link
Collaborator

@abetomo abetomo left a comment

👍

@shadowspawn shadowspawn merged commit 6c06528 into tj:release/8.x May 18, 2021
12 checks passed
@shadowspawn shadowspawn deleted the feature/access-option-values branch May 18, 2021
@shadowspawn shadowspawn added the pending release label May 18, 2021
@shadowspawn shadowspawn removed the pending release label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants