Ruby warnings fixed, such as: #87
Conversation
ralfclaassens
commented
Jan 12, 2015
ralfclaassens
commented
- warning: loading in progress, circular require considered harmful
- warning: instance variable @always_trace not initialized
- warning: loading in progress, circular require considered harmful - warning: instance variable @always_trace not initialized
| @@ -1,7 +1,4 @@ | |||
|
|
|||
| require 'commander' | |||
| require 'commander/delegates' | |||
There was a problem hiding this comment.
I think this is a potential problem because the readme suggests just using require 'commander/import' in programs.
There was a problem hiding this comment.
Maybe these requires can be conditional?
There was a problem hiding this comment.
Actually, commander/import shouldn't be loaded by require 'commander' so maybe there's actually no circular require in this file.
There was a problem hiding this comment.
Sorry, missed that. But I'm sure there is a circular require. I'll investigate this.
|
Looks good except for the change to |
|
Can you give an example of how the warning can be triggered? I haven't seen it running specs or programs. Let me know and we can reopen this. |
|
The warning can be triggered by executing 'ruby -W < ruby-app-which-requires-commander >' |
