Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled showing trace when always_trace is active #91

Merged
merged 2 commits into from
Jan 29, 2015
Merged

Disabled showing trace when always_trace is active #91

merged 2 commits into from
Jan 29, 2015

Conversation

KrauseFx
Copy link
Contributor

Fixes #90

@@ -57,7 +57,7 @@ def run!
return
end
global_option('-v', '--version', 'Display version information') { say version; return }
global_option('-t', '--trace', 'Display backtrace when an error occurs') { trace = true } unless @never_trace
global_option('-t', '--trace', 'Display backtrace when an error occurs') { trace = true } unless (@never_trace or @always_trace)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer || to or

@KrauseFx
Copy link
Contributor Author

Updated pull request 👍

ggilder added a commit that referenced this pull request Jan 29, 2015
Disabled showing trace when always_trace is active
@ggilder ggilder merged commit b614628 into tj:master Jan 29, 2015
@ggilder
Copy link
Collaborator

ggilder commented Jan 29, 2015

Thanks!

@KrauseFx KrauseFx deleted the patch-1 branch January 29, 2015 20:30
@ggilder
Copy link
Collaborator

ggilder commented Feb 8, 2015

This has been released in commander 4.3.0 now.

@KrauseFx
Copy link
Contributor Author

KrauseFx commented Feb 8, 2015

👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using always_trace! should hide the --trace option in the help output
2 participants