peerDependencies to optionalDependencies (package.json)

[knoxcard]

optionalDependencies dont spill a bunch of warnings on the screen. I use ioredis and it's reminding me to always install redis and redis-mock. every time I run yarn upgrade --latest.

optionalDependencies
Optional dependencies are just that: optional. If they fail to install, Yarn will still say the install process was successful.This is useful for dependencies that won’t necessarily work on every machine and you have a fallback plan in case they are not installed (e.g. Watchman).
https://yarnpkg.com/lang/en/docs/dependency-types/

[wavded]

Yep, that makes sense to me, I suppose this library technically doesn't require any dependencies, but won't do a whole lot with a Redis client 🤣

[silentroach]

With peerDependencies npm will not install ioredis and redis and redis-mock, but with optionalDependencies it will.
And it is not great though. Why should I have ioredis package in my node modules if I use redis client?

you have a fallback plan in case they are not installed

What fallback do you mean? Connect-redis will not work if I will not provide any client in init function.

[knoxcard]

@silentroach - why a thumbs down??
You can provide either a redis or ioredis client.

Before this module would default to redis. Lets say I wanted to use ioredis instead. I would have to keep the redis package installed in my repository. Now, you can just keep the ioredis package installed and remove the redis package. Only one client required, no extra fat!

[silentroach]

I know, but I don't want them both to be installed

[knoxcard]

I know, but I don't want them both to be installed

Only install the redis client you're going to use. If another one is also installed, remove it. Basically, you should have redis or ioredis.

[knoxcard]

@silentroach - wait, this just hit me, lol. ummm, dependencies should be completely removed. Is that what you meant? lol, time for another pull request!

[silentroach]

They both are installed now with connect-redis because of they are optional dependencies.

With peerDependencies I can install only the client I need:

[knoxcard]

Crap! okay.
So I've made a terrible mistake, we need to change it back to how it was?

What about removing dependencies altogether?

@wavded - oopsy, looks like I made a booboo!

[silentroach]

I think peerDependencies were ok :}

[knoxcard]

Sure, right now that sounds like the better option.
But what would happen, if we just drop dependencies altogether?

069497c

[silentroach]

peerDependencies are something like a contract, it is very useful, but it is better to think about it not like a dependency to some package, but to some version of package. If connect-redis will work with all versions of that packages, you just don't need to describe them in dependencies.

[knoxcard]

But at the same time, we're moving forward in time, who's still using super old dependencies? I think it's better those who do receive a console error.

[knoxcard]

@wavded - seems that I completely misunderstood how optionalDependencies works. Currently, when users install connect-redis, all defined packages, in this case three (ioredis, redis, redis-mock) are included as well. :-(

Even setting peerDependencies reminds the user of these three packages, every time they install or upgrade, which also appears to be incorrect, right?

Would the best option be to simply remove dependencies?
#282

[wavded]

Thanks for the report @silentroach, yes @knoxcard seems the best course of action is to remove it from the dependencies all together. Of course it will exist in devDependencies for testing.

[knoxcard]

Yes, major thanks to @silentroach for reporting that! This repo is downloaded 130,000+ times per week, All of those unnecessary downloads would have continued, until someone else pointed that out.