Support for concurrent sessions #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavded
changed the title
|
Thx @xarnze, I like this implementation and thx for writing the tests. |
zkrising
added a commit
to zkrising/connect-redis
that referenced
this pull request
Feb 16, 2022
zkrising
added a commit
to zkrising/connect-redis
that referenced
this pull request
Feb 16, 2022
This reverts commit 42d3430.
zkrising
added a commit
to zkrising/connect-redis
that referenced
this pull request
Feb 16, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
This fixes an issue we experienced where multiple requests modifying the session are in progress at the same time, before this fix the last one to complete looses the changes made by the other in flight request. After this fix changes are merged in from all in flight requests.
Hopefully this helps someone :)