add confirmation to git-undo

[tj]

bad things can happen if you're not careful :) we should show a list of descriptions etc

[matthewmueller]

So I actually don't think this command should do a hard reset.

It looks like this command has been around for a while so maybe people are used to it, but it seems to me that the point of this bundle is to make git land an easier and more forgiving place...

To me, undo, reminds me of cmd + z. Cmd + z is quick, recoverable (with redo), and used without much thought or worry. Right now this command reverses your most recent commit, and potentially blows away an hour's worth of work along with it, an action that can't be reversed easily.

I think a warning message would be fine, but I also don't think the name of the command is quite right.

[tj]

yeah i dont disagree with that. I wasn't the one who added it ( and I've rarely used it because of this issue ), but a few people have done exactly what you mention. We could just get rid of it

[rauchg]

Let's get rid of it. I just had another accident with it haha

[muhtasib]

How about letting it do a soft reset instead? This way users won't lose their changes. Previous files/changes will be in the local directory after the undo command is run.

I submitted a pull request for this. Let me know if you'd like me to make any changes. I like the command, so I advocate for keeping it : )

[bittner]

This issue can be closed.

[spacewander]

Closed.