adds a goproxy resolver #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgersh
force-pushed
the
goproxy-support
branch
3 times, most recently
from
5aa8e74
to
cfa721f
Compare
Currently we've hardcoded the proxy, this is just a wip for now and will be configurable from the root. This is just a resolver for now to make sure that the code style, errors, and the small refactors look good here. The future direction of this would to be to attempt to use the goproxy resolver and then failing that, fall back to GitHub (but open to suggestions here).
zachgersh
force-pushed
the
goproxy-support
branch
from
cfa721f
to
6d4adc8
Compare
|
awesomeee! I'll try to help review tonight or tomorrow. I'm not sure we even need to fall-back on the GitHub one I have, but it might be nice to later introduce support for pre-compiled binaries #16 |
|
@tj - thanks friend (this just the beginning). Wanted to make sure you liked this and then it should be trivial to wire up the rest of it into the |
|
Hey @tj ready to do some more work on this but wanted to check in. Was this direction good? I am going to add more to this PR if so! |
|
Hey sorry for the delay, looks great to me so far! Thanks for hacking on it, I don't see anything I would tweak |
|
Thanks @tj I will come back to this during the weekend and finish it off 👯 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we've hardcoded the proxy, this is just a wip for now and will
be configurable from the root.
This is just a resolver for now to make sure that the code style,
errors, and the small refactors look good here.
The future direction of this would to be to attempt to use
the goproxy resolver and then failing that, fall back to
GitHub (but open to suggestions here).
Please open an issue and discuss changes before spending time on them, unless the change is trivial or an issue already exists.